New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation for minute_read. #1211

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
2 participants
@DDoSolitary
Contributor

DDoSolitary commented Aug 31, 2017

Although the original one can be understood, it seems strange for a native Chinese speaker. I think the updated version should be better.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 31, 2017

Owner

How bad is the original one? I get a lot of these requests to change translated text for a given locale and it becomes a battle with people constantly submitting PRs to change it back and fourth.

The ui-text.yml data file is completely editable by the user. My intention was to provide a base line of texts and then its up to the user to tailor those to suit their site/needs.

Owner

mmistakes commented Aug 31, 2017

How bad is the original one? I get a lot of these requests to change translated text for a given locale and it becomes a battle with people constantly submitting PRs to change it back and fourth.

The ui-text.yml data file is completely editable by the user. My intention was to provide a base line of texts and then its up to the user to tailor those to suit their site/needs.

@DDoSolitary

This comment has been minimized.

Show comment
Hide comment
@DDoSolitary

DDoSolitary Sep 1, 2017

Contributor

I believe that any native Chinese speaker would say that the updated version is better (though
definitely not the best, I always fail my Chinese exams XD). But it is really difficult for me to explain how is it better.

I love your project and I just wanted to make this project better. At the same time, I understand that it's somewhat annoying to deal with such translation problems. It is up to you to decide whether to merge this PR.

Contributor

DDoSolitary commented Sep 1, 2017

I believe that any native Chinese speaker would say that the updated version is better (though
definitely not the best, I always fail my Chinese exams XD). But it is really difficult for me to explain how is it better.

I love your project and I just wanted to make this project better. At the same time, I understand that it's somewhat annoying to deal with such translation problems. It is up to you to decide whether to merge this PR.

@mmistakes mmistakes merged commit dddf865 into mmistakes:master Sep 1, 2017

@DDoSolitary DDoSolitary deleted the DDoSolitary:chinese-minute-read-patch branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment