New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish locale #1304

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@kbl
Contributor

kbl commented Oct 14, 2017

Adding polish locale to ui-text.yml

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Oct 16, 2017

Owner

Thanks for the PR!

Owner

mmistakes commented Oct 16, 2017

Thanks for the PR!

@mmistakes mmistakes merged commit 52f2451 into mmistakes:master Oct 16, 2017

mmistakes added a commit that referenced this pull request Oct 16, 2017

@kbl

This comment has been minimized.

Show comment
Hide comment
@kbl

kbl Oct 16, 2017

Contributor

NP, I should rather say - thank you for the theme ;)

Unfortunately my translation isn't "perfect". In Polish there is a difference between "next" used with pages and posts. The same is true for reading time, depending on number "minutes" could have 3 different forms (https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/pl.yml#L106) ;)

I don't know what is your intention there. Would you like rather to keep it simple/concise or support all language quirks.

Contributor

kbl commented Oct 16, 2017

NP, I should rather say - thank you for the theme ;)

Unfortunately my translation isn't "perfect". In Polish there is a difference between "next" used with pages and posts. The same is true for reading time, depending on number "minutes" could have 3 different forms (https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/pl.yml#L106) ;)

I don't know what is your intention there. Would you like rather to keep it simple/concise or support all language quirks.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Oct 16, 2017

Owner

Simple and concise is fine. Since the data file is editable my intention is just to provide a starting point and if someone wants to tailor the text to suit their needs they can.

Owner

mmistakes commented Oct 16, 2017

Simple and concise is fine. Since the data file is editable my intention is just to provide a starting point and if someone wants to tailor the text to suit their needs they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment