New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google plus link #1319

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@sumibi-yakitori
Contributor

sumibi-yakitori commented Oct 26, 2017

No description provided.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Oct 26, 2017

Owner

Can you give some detail on why this fix is needed? Google+ URLs with the + in them still exist and are valid. Example: https://plus.google.com/+MichaelRoseDesign.

Owner

mmistakes commented Oct 26, 2017

Can you give some detail on why this fix is needed? Google+ URLs with the + in them still exist and are valid. Example: https://plus.google.com/+MichaelRoseDesign.

@sumibi-yakitori

This comment has been minimized.

Show comment
Hide comment
@sumibi-yakitori
Contributor

sumibi-yakitori commented Oct 26, 2017

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Oct 26, 2017

Owner

That makes sense then. I believe the + is for those who have set a vanity URL.

Owner

mmistakes commented Oct 26, 2017

That makes sense then. I believe the + is for those who have set a vanity URL.

@sumibi-yakitori

This comment has been minimized.

Show comment
Hide comment
@sumibi-yakitori

sumibi-yakitori Oct 26, 2017

Contributor

I now know that google plus can make vanity url.
But my google plus account does not seem to be able to make vanity url.

You may reject this pull request.

Contributor

sumibi-yakitori commented Oct 26, 2017

I now know that google plus can make vanity url.
But my google plus account does not seem to be able to make vanity url.

You may reject this pull request.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Oct 26, 2017

Owner

I've accepted the PR and will merge it in when I get a chance.

It's probably better to omit the + as you have to allow anyone with a profile to use it.

Owner

mmistakes commented Oct 26, 2017

I've accepted the PR and will merge it in when I get a chance.

It's probably better to omit the + as you have to allow anyone with a profile to use it.

@sumibi-yakitori

This comment has been minimized.

Show comment
Hide comment
@sumibi-yakitori

sumibi-yakitori Oct 26, 2017

Contributor

Thank you.

Contributor

sumibi-yakitori commented Oct 26, 2017

Thank you.

@mmistakes mmistakes merged commit cf9a908 into mmistakes:master Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment