New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update social-share.html #1357

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@DannieBGoode
Contributor

DannieBGoode commented Nov 16, 2017

This way when clicking on the share on a social networks buttons, a share popup will open instead of forcing the share in the same window.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 16, 2017

Owner

What's the experience like on mobile? I see you have hardcoded widths in there at 500px. Will that force the main container to push out and mess up the layout?

Owner

mmistakes commented Nov 16, 2017

What's the experience like on mobile? I see you have hardcoded widths in there at 500px. Will that force the main container to push out and mess up the layout?

@DannieBGoode

This comment has been minimized.

Show comment
Hide comment
@DannieBGoode

DannieBGoode Nov 16, 2017

Contributor

The width and the height are set as initial values, but the popup adjusts itself to the size needed by the content it hosts. No layouts are messed up.

The experience on mobile is x100 times better. Allow me to explain:

  • Right now in the official mm master branch when you try to share, you are redirected to facebook and lose the blog. When you complete the share you are left on a blank window (just tested it) and you need to click on the BACK button until you are back again at the blog.
  • With my fix, a new tab opens on top of the one containing the web with the share options, once you finish the share this window closes itself and you find yourself again at the blog (which was in the tab underneath).

I suggest you test it out yourself, if you see anything wrong i'll have a look.

Contributor

DannieBGoode commented Nov 16, 2017

The width and the height are set as initial values, but the popup adjusts itself to the size needed by the content it hosts. No layouts are messed up.

The experience on mobile is x100 times better. Allow me to explain:

  • Right now in the official mm master branch when you try to share, you are redirected to facebook and lose the blog. When you complete the share you are left on a blank window (just tested it) and you need to click on the BACK button until you are back again at the blog.
  • With my fix, a new tab opens on top of the one containing the web with the share options, once you finish the share this window closes itself and you find yourself again at the blog (which was in the tab underneath).

I suggest you test it out yourself, if you see anything wrong i'll have a look.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 20, 2017

Owner

Thanks.... looks good!

Owner

mmistakes commented Nov 20, 2017

Thanks.... looks good!

@mmistakes mmistakes merged commit 696d589 into mmistakes:master Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment