New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize JSON data #1449

Merged
merged 10 commits into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@nickgarlis
Contributor

nickgarlis commented Jan 4, 2018

I was thinking of maybe moving the last function ( where the search takes place and the results are displayed ) into a new file too but I am not currently sure if it's going to stay the same for every language that I add.

Live Preview

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 4, 2018

Owner

Looking good. We might have to think about truncating the excerpts size, but looking at the the lunr-store.js for the MM demo site it's not too bad.

I'm showing around 246 kB for an index with all of the body content. Which isn't great, but not awful since the searches for "search" actually produce results now. Guess if someone has a 1,000 post site it might be too big, but otherwise I'm fine with leaving it as is for now.

Owner

mmistakes commented Jan 4, 2018

Looking good. We might have to think about truncating the excerpts size, but looking at the the lunr-store.js for the MM demo site it's not too bad.

I'm showing around 246 kB for an index with all of the body content. Which isn't great, but not awful since the searches for "search" actually produce results now. Guess if someone has a 1,000 post site it might be too big, but otherwise I'm fine with leaving it as is for now.

Show outdated Hide outdated _includes/scripts.html Outdated

@mmistakes mmistakes merged commit 3fb63f3 into mmistakes:master Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment