New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for division by zero issue #345

Merged
merged 3 commits into from Jun 7, 2016

Conversation

Projects
None yet
2 participants
@Scot3004
Copy link
Contributor

Scot3004 commented Jun 7, 2016

#317 could pass when the parameter words_per_minute is not defined in _config.yml and the parameter read_time at post are defined in true.

The PR show a message when detects undefined the parameter words_per_minute in read_time.html
the other parameter is handled by other parameter outside this file.

mmistakes and others added some commits Jun 7, 2016

Undefined word_per_minutes parameter division by zero
If the parameter words_per_minute at _config.yml is not defined and the template says that must show read_time then will be divide a number by zero, a fix is verify that parameter and show a message when this is empty or zero. already localized for spanish

@mmistakes mmistakes merged commit 01cfcf0 into mmistakes:master Jun 7, 2016

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this pull request Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment