New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different feed providers #379

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@gabor-meszaros
Contributor

gabor-meszaros commented Jun 25, 2016

Solution for #378 . Could you please review it? I am quite new in Jekyll and Liquid. :) Thank you!

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 25, 2016

Owner

I'm onboard with this enhancement. One small suggestion. What of instead of doing something similar to the comments provider customization, we go with something much simpler:

  1. By default use feed.xml that builds with the jekyll-feed plugin.
  2. All the default feed.xml to be overriden by specifying a path to an external one eg: http://feeds.feedburner.com/whatever or anywhere else.

Removing the provider stuff makes it easier to use any other service.

Thinking _config.yml would look something like

feed:
  path: # blank (default) uses feed.xml

And _includes/footer.html

  <li><a href="{% if site.feed.path %}{{ site.feed.path }}{% else %}{{ base_path }}/feed.xml{% endif %}"><i class="fa fa-fw fa-rss-square" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].feed_label }}</a></li>
Owner

mmistakes commented Jun 25, 2016

I'm onboard with this enhancement. One small suggestion. What of instead of doing something similar to the comments provider customization, we go with something much simpler:

  1. By default use feed.xml that builds with the jekyll-feed plugin.
  2. All the default feed.xml to be overriden by specifying a path to an external one eg: http://feeds.feedburner.com/whatever or anywhere else.

Removing the provider stuff makes it easier to use any other service.

Thinking _config.yml would look something like

feed:
  path: # blank (default) uses feed.xml

And _includes/footer.html

  <li><a href="{% if site.feed.path %}{{ site.feed.path }}{% else %}{{ base_path }}/feed.xml{% endif %}"><i class="fa fa-fw fa-rss-square" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].feed_label }}</a></li>
Make the feed provider more flexible
Followed the recommendation of @mmistakes. Link:
#379
@gabor-meszaros

This comment has been minimized.

Show comment
Hide comment
@gabor-meszaros

gabor-meszaros Jun 26, 2016

Contributor

Thank you for the review! It makes sense and indeed less complicated than my original solution.

I did the modifications. Is it anything else that I can do to improve it?

Contributor

gabor-meszaros commented Jun 26, 2016

Thank you for the review! It makes sense and indeed less complicated than my original solution.

I did the modifications. Is it anything else that I can do to improve it?

Show outdated Hide outdated _config.yml Outdated
Show outdated Hide outdated _includes/footer.html Outdated
@gabor-meszaros

This comment has been minimized.

Show comment
Hide comment
@gabor-meszaros

gabor-meszaros Jul 26, 2016

Contributor

Thank you for the suggestions! I am sorry for the quite late answer...

I noticed that some commits were added to the repository since my last commit, I am not sure if I can do a rebase in this situation. If it is possible, could you please give me some hints about how to do it?

I do not want to hack around if there is a better solution to this, but I can fork your repo again, do the modification, and create a new PR if that makes the git log more readable.

What is your opinion? Thanks!

Contributor

gabor-meszaros commented Jul 26, 2016

Thank you for the suggestions! I am sorry for the quite late answer...

I noticed that some commits were added to the repository since my last commit, I am not sure if I can do a rebase in this situation. If it is possible, could you please give me some hints about how to do it?

I do not want to hack around if there is a better solution to this, but I can fork your repo again, do the modification, and create a new PR if that makes the git log more readable.

What is your opinion? Thanks!

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 26, 2016

Owner

Rebasing and flattening everything down into a single commit would probably be cleaner. But I'm not the best at Git and haven't had much luck rebasing myself.

If you don't mind, probably easier to just refork and open a new PR.

Owner

mmistakes commented Jul 26, 2016

Rebasing and flattening everything down into a single commit would probably be cleaner. But I'm not the best at Git and haven't had much luck rebasing myself.

If you don't mind, probably easier to just refork and open a new PR.

@gabor-meszaros

This comment has been minimized.

Show comment
Hide comment
@gabor-meszaros

gabor-meszaros Jul 26, 2016

Contributor

Sure, I will do it right now. Thanks for your patience!

Contributor

gabor-meszaros commented Jul 26, 2016

Sure, I will do it right now. Thanks for your patience!

@gabor-meszaros

This comment has been minimized.

Show comment
Hide comment
@gabor-meszaros

gabor-meszaros Jul 26, 2016

Contributor

I added the new PR. Could you please review it whether it is OK? Thanks.

Contributor

gabor-meszaros commented Jul 26, 2016

I added the new PR. Could you please review it whether it is OK? Thanks.

@mmistakes mmistakes closed this in 2cfad13 Jul 26, 2016

mmistakes added a commit that referenced this pull request Jul 26, 2016

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this pull request Dec 7, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this pull request Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment