New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarified comment for author.stackoverflow value in _config.yml #487

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rschaerer
Contributor

rschaerer commented Aug 28, 2016

Initial Situation

  • The author.stackoverflow variable was commentet with # http://stackoverflow.com/users/123456/username, which led me to the conclusion that I should add the whole url as value.
  • The stackoverflow combination of numeric id / username isn't self-explanatory.

Proposed Change

Change the comment to explicit state the requested value "123456/username" and append the whole demo url to show where the needed value can be found.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 30, 2016

Owner

Thanks. Merged into develop and will push with the next theme release.

ref: d3ac112

Owner

mmistakes commented Aug 30, 2016

Thanks. Merged into develop and will push with the next theme release.

ref: d3ac112

@mmistakes mmistakes closed this Aug 30, 2016

@rschaerer rschaerer deleted the uru-ch:clarified-comment-stackoverflow-author-profile branch Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment