New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get Follow-Button label from ui-text and default to "Follow" #496

Merged
merged 1 commit into from Sep 2, 2016

Conversation

Projects
None yet
2 participants
@rschaerer
Copy link
Contributor

rschaerer commented Sep 1, 2016

The Follow button Label wasn't localized with the ui-text value, now it is with default to "Follow".

The colon from the end of the ui-text value of follow_label is being removed by the liquid filter remove: ":"

@mmistakes mmistakes merged commit 0c2d3bb into mmistakes:develop Sep 2, 2016

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Sep 2, 2016

Thanks for the PR!

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this pull request Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment