New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes: Enhance Twitter share link #538

Merged
merged 1 commit into from Sep 19, 2016

Conversation

Projects
None yet
2 participants
@kylemanna
Contributor

kylemanna commented Sep 18, 2016

  • Include the page title before the URL
  • If twitter.username is set, pass the via paramter for attribution
includes: Enhance Twitter share link
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
@mmistakes

Looks good. Thanks for the PR!

@mmistakes mmistakes merged commit d4ee7ff into mmistakes:develop Sep 19, 2016

mmistakes added a commit that referenced this pull request Sep 19, 2016

includes: Enhance Twitter share link (#538)
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution

@kylemanna kylemanna deleted the kylemanna:twitter-share-enhancement branch Sep 19, 2016

TheCodedSelf pushed a commit to TheCodedSelf/thecodedself.github.io that referenced this pull request Dec 7, 2016

includes: Enhance Twitter share link (mmistakes#538)
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017

includes: Enhance Twitter share link (mmistakes#538)
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this pull request Jul 27, 2018

includes: Enhance Twitter share link (mmistakes#538)
* Include the page title before the URL
* If twitter.username is set, pass the `via` paramter for attribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment