New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive video header and include with docs #788

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
3 participants
@justintoo
Contributor

justintoo commented Jan 23, 2017

Follow-up fixes for #781:

  1. Submit pull request against the develop branch and not master.
  2. Fix indenting in (2 space vs. 4)
  3. Move inline CSS to Sass partial (_sass/_utlities.scss)
  4. Replace apostrophes with double quotes ie:
    instead of

Additional enhancements:

  1. Refactored embed video from _includes/page__hero_video.html into _includes/responsive_video
  2. Updated _includes/page__hero_video.html to use {% include responsive_video id="..." provider="..." %}
  3. Updated documentation with 1) blog post for layout with header video, and 2) new "Video" section in the Helpers documentation.

Let me know if there's any further modifications required for merging. Thanks! =)

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jan 23, 2017

Owner

Quick look and this looks great. I'll have a closer look and let you know. Appreciate you documenting and adding examples too 😄

Owner

mmistakes commented Jan 23, 2017

Quick look and this looks great. I'll have a closer look and let you know. Appreciate you documenting and adding examples too 😄

@mmistakes mmistakes merged commit 65a6654 into mmistakes:develop Jan 24, 2017

NicolasT added a commit to NicolasT/nicolast.github.io that referenced this pull request Jan 29, 2017

Merge tag '4.2.1'
* tag '4.2.1': (22 commits)
  Bump version to 4.2.1
  Update CHANGELOG and history
  Document moving paginated home page to an alternate location
  Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764)
  Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764)
  Add https prefix to google-universal embed code. (mmistakes#772)
  Add https prefix to google-universal embed code. (mmistakes#772)
  Bump version to 4.2.0
  Bump jekyll-sitemap to (1.0)
  Update CHANGELOG and history
  Improve video helper documentation
  Add video header support to `archive` and `splash` layouts
  Rename `responsive_video` helper to `video`
  Add some white-space below video embeds
  Add Nepali (Nepalese) text
  Add page hero video for vimeo/youtube using embedresponsively.com code (mmistakes#788)
  Nepalese Language (mmistakes#785)
  invalid `analytics` example fix (mmistakes#783)
  Remove borders from table elements found in Google Custom Search Engine widget - Close mmistakes#759
  Complete Simplified Chinese Translation of Theme UI (mmistakes#747)
  ...

wetty added a commit to wetty/wetty-web that referenced this pull request Feb 7, 2017

Merge branch 'master' of https://github.com/mmistakes/minimal-mistakes
…into gh-pages

* 'master' of https://github.com/mmistakes/minimal-mistakes: (22 commits)
  Bump version to 4.2.1
  Update CHANGELOG and history
  Document moving paginated home page to an alternate location
  Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764)
  Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764)
  Add https prefix to google-universal embed code. (mmistakes#772)
  Add https prefix to google-universal embed code. (mmistakes#772)
  Bump version to 4.2.0
  Bump jekyll-sitemap to (1.0)
  Update CHANGELOG and history
  Improve video helper documentation
  Add video header support to `archive` and `splash` layouts
  Rename `responsive_video` helper to `video`
  Add some white-space below video embeds
  Add Nepali (Nepalese) text
  Add page hero video for vimeo/youtube using embedresponsively.com code (mmistakes#788)
  Nepalese Language (mmistakes#785)
  invalid `analytics` example fix (mmistakes#783)
  Remove borders from table elements found in Google Custom Search Engine widget - Close mmistakes#759
  Complete Simplified Chinese Translation of Theme UI (mmistakes#747)
  ...

# Conflicts:
#	CHANGELOG.md
#	README.md
#	docs/_data/ui-text.yml
#	docs/_docs/05-configuration.md
#	docs/_docs/08-ui-text.md
#	docs/_docs/10-layouts.md
#	docs/_docs/14-helpers.md
#	docs/_docs/17-javascript.md
#	docs/_docs/18-history.md
#	docs/_includes/analytics-providers/google-universal.html
#	docs/_includes/page__hero.html
#	docs/_includes/paginator.html
#	docs/_layouts/archive.html
#	docs/_layouts/single.html
#	docs/_layouts/splash.html
#	docs/_pages/about.md
#	docs/_pages/home.md
#	docs/_sass/_utilities.scss
#	docs/assets/js/_main.js
#	docs/assets/js/main.min.js
#	minimal-mistakes-jekyll.gemspec
#	test/_data/ui-text.yml
@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Apr 10, 2017

Contributor
Contributor

jhabdas commented Apr 10, 2017

<!-- Courtesy of embedresponsively.com //-->
<div class="responsive-video-container">
{% if video_provider == "vimeo" %}
<iframe src="http://player.vimeo.com/video/{{ video_id }}" frameborder="0" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>

This comment has been minimized.

@jhabdas

jhabdas Apr 10, 2017

Contributor

Hey should these be protocol relative? This breaks when served over HTTPS

@jhabdas

jhabdas Apr 10, 2017

Contributor

Hey should these be protocol relative? This breaks when served over HTTPS

This comment has been minimized.

@mmistakes

mmistakes Apr 10, 2017

Owner

Yes it should be protocol relative.

@mmistakes

mmistakes Apr 10, 2017

Owner

Yes it should be protocol relative.

This comment has been minimized.

@jhabdas

jhabdas Apr 10, 2017

Contributor

Incoming pull

@jhabdas

jhabdas Apr 10, 2017

Contributor

Incoming pull

This comment has been minimized.

@mmistakes

mmistakes Apr 10, 2017

Owner

Maybe just do https://, I just checked the embeds on Vimeo and that's what they default to. The YouTube one is that way as well.

@mmistakes

mmistakes Apr 10, 2017

Owner

Maybe just do https://, I just checked the embeds on Vimeo and that's what they default to. The YouTube one is that way as well.

This comment has been minimized.

@jhabdas

jhabdas Apr 10, 2017

Contributor

Done

@jhabdas

jhabdas Apr 10, 2017

Contributor

Done

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this pull request Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment