New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buggy conditional around related posts header #901

Merged
merged 1 commit into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@Bounga
Contributor

Bounga commented Mar 15, 2017

This removes a buggy conditional that checks if related_label is
available in translations and prevents header to be displayed in
some edge cases.

Fix #900

Remove buggy conditional around related posts header
This removes a buggy conditional that checks if `related_label` is
available in translations before displaying the header for related
posts but this header already handle missing translation by using a
default string.

With this fix the header is displayed even if the translation for this
label isn't available.

Fix #900
@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Mar 16, 2017

Owner

Thanks for taking care of this @Bounga.

Owner

mmistakes commented Mar 16, 2017

Thanks for taking care of this @Bounga.

@mmistakes mmistakes merged commit 958b399 into mmistakes:develop Mar 16, 2017

RobinYu added a commit to RobinYu/robinyu.github.io that referenced this pull request Mar 18, 2017

Remove buggy conditional around related posts header (mmistakes#901)
This removes a buggy conditional that checks if `related_label` is
available in translations before displaying the header for related
posts but this header already handle missing translation by using a
default string.

With this fix the header is displayed even if the translation for this
label isn't available.

Fix mmistakes#900

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this pull request Jul 27, 2018

Remove buggy conditional around related posts header (mmistakes#901)
This removes a buggy conditional that checks if `related_label` is
available in translations before displaying the header for related
posts but this header already handle missing translation by using a
default string.

With this fix the header is displayed even if the translation for this
label isn't available.

Fix mmistakes#900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment