New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(includes/video): use https always #945

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
2 participants
@jhabdas
Contributor

jhabdas commented Apr 10, 2017

when served over https the vimeo link was failing. defer scheme used for video iframe src urls
realtive to the current protocol (e.g. http or https)

closes #944

@jhabdas jhabdas changed the title from fix(includes/video): use protocol-relative video urls to fix(includes/video): use https always Apr 10, 2017

@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Apr 10, 2017

Contributor

Updated to use HTTPs by default. My understanding is that HTTPS sites will not pass referrer info back to non-HTTPs. If so, oh well? 😺

Contributor

jhabdas commented Apr 10, 2017

Updated to use HTTPs by default. My understanding is that HTTPS sites will not pass referrer info back to non-HTTPs. If so, oh well? 😺

@mmistakes mmistakes merged commit 706531b into mmistakes:master Apr 19, 2017

RobinYu added a commit to RobinYu/robinyu.github.io that referenced this pull request May 8, 2017

NicolasT added a commit to NicolasT/nicolast.github.io that referenced this pull request May 30, 2017

Merge tag '4.4.1'
* tag '4.4.1': (33 commits)
  Release 💎 4.4.1
  Transition “hamburger” navicon on click to “X” navicon by adding `.close` to button - Close 969
  Add link to comment
  New comment. (mmistakes#968)
  New comment. (mmistakes#967)
  Update CHANGELOG and history
  Sync `/docs` with root changes
  Update ui-text.yml (mmistakes#958)
  fix(includes/video): use https always (mmistakes#945)
  Update history
  Release 💎 4.4.0
  Move SCSS partials to `/_sass/minimal-mistakes` for easier CSS customization
  Fixed link errors in docs (mmistakes#946)
  Add closing `}`
  Fix `.masthead` and `.page__footer` overlapping full screen video elements. - Close mmistakes#933
  Update CHANGELOG and history
  Add ProTip about installing unreleased version on `master`
  Replace modified with last_modified_at (mmistakes#930)
  Update CHANGELOG and history
  Add Lithuanian language/locale (mmistakes#924)
  ...

 Conflicts:
	.github/CONTRIBUTING.md
	.github/ISSUE_TEMPLATE.md
	CHANGELOG.md
	README.md
	docs/_data/navigation.yml
	docs/_data/ui-text.yml
	docs/_docs/01-quick-start-guide.md
	docs/_docs/02-structure.md
	docs/_docs/03-installation.md
	docs/_docs/04-upgrading.md
	docs/_docs/05-configuration.md
	docs/_docs/06-overriding-theme-defaults.md
	docs/_docs/07-navigation.md
	docs/_docs/08-ui-text.md
	docs/_docs/09-authors.md
	docs/_docs/10-layouts.md
	docs/_docs/11-posts.md
	docs/_docs/12-pages.md
	docs/_docs/13-collections.md
	docs/_docs/14-helpers.md
	docs/_docs/15-utility-classes.md
	docs/_docs/16-stylesheets.md
	docs/_docs/17-javascript.md
	docs/_docs/18-history.md
	docs/_docs/19-contributing.md
	docs/_docs/20-docs-2-2.md
	docs/_docs/21-license.md
	docs/_includes/video
	docs/_layouts/default.html
	docs/_layouts/single.html
	docs/_layouts/splash.html
	docs/_pages/about.md
	docs/_pages/home.md
	docs/_pages/terms.md
	docs/_posts/2010-01-07-post-modified.md
	docs/_posts/2012-03-15-layout-header-overlay-image.md
	docs/_posts/2013-08-16-markup-syntax-highlighting.md
	docs/_posts/2016-09-21-gemified-theme-alpha.md
	docs/_posts/2016-10-06-gemified-theme-beta.md
	docs/_sass/minimal-mistakes/_animations.scss
	docs/_sass/minimal-mistakes/_archive.scss
	docs/_sass/minimal-mistakes/_base.scss
	docs/_sass/minimal-mistakes/_buttons.scss
	docs/_sass/minimal-mistakes/_footer.scss
	docs/_sass/minimal-mistakes/_forms.scss
	docs/_sass/minimal-mistakes/_masthead.scss
	docs/_sass/minimal-mistakes/_mixins.scss
	docs/_sass/minimal-mistakes/_navigation.scss
	docs/_sass/minimal-mistakes/_notices.scss
	docs/_sass/minimal-mistakes/_page.scss
	docs/_sass/minimal-mistakes/_reset.scss
	docs/_sass/minimal-mistakes/_sidebar.scss
	docs/_sass/minimal-mistakes/_syntax.scss
	docs/_sass/minimal-mistakes/_tables.scss
	docs/_sass/minimal-mistakes/_utilities.scss
	docs/_sass/minimal-mistakes/_variables.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_breakpoint.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_context.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_legacy-settings.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_no-query.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_parsers.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_respond-to.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/_settings.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_double.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_query.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_resolution.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_single.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_triple.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default-pair.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_double-string.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/resolution/_resolution.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/single/_default.scss
	docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/triple/_default.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_animated.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_bordered-pulled.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_core.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_fixed-width.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_font-awesome.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_icons.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_larger.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_list.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_mixins.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_path.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_rotated-flipped.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_screen-reader.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_stacked.scss
	docs/_sass/minimal-mistakes/vendor/font-awesome/_variables.scss
	docs/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss
	docs/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss
	docs/_sass/minimal-mistakes/vendor/susy/_su.scss
	docs/_sass/minimal-mistakes/vendor/susy/_susy.scss
	docs/_sass/minimal-mistakes/vendor/susy/_susyone.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/_su.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susy.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susyone.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_background.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_bleed.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_box-sizing.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_breakpoint-plugin.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_container.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_context.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gallery.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_grids.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gutters.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_isolate.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_margins.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_padding.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_rows.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_settings.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_span.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_validation.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_background.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_functions.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_grid.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_isolation.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_margin.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_media.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_padding.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_settings.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/_float.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/_shared.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/_support.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_container.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_end.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_isolate.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_span.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_background.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_container.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_direction.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_inspect.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_margins.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_output.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_padding.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_background.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_box-sizing.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_clearfix.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_prefix.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_rem.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_support.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/su/_grid.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/su/_settings.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/su/_utilities.scss
	docs/_sass/minimal-mistakes/vendor/susy/susy/su/_validation.scss
	docs/assets/css/main.scss
	docs/assets/js/main.min.js
	docs/assets/js/plugins/jquery.greedy-navigation.js
	minimal-mistakes-jekyll.gemspec
	test/_pages/terms.md
	test/_posts/2010-01-07-post-modified.md
	test/_posts/2012-03-15-layout-header-overlay-image.md
	test/_posts/2013-08-16-markup-syntax-highlighting.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment