Merged
Conversation
Owner
@supremebeing7 completely agree!
Yes, that would be preferable 😄 |
mmozuras
reviewed
Apr 2, 2017
| @config.summary_character_limit_number.to_i | ||
| end | ||
|
|
||
| def error_message |
Owner
There was a problem hiding this comment.
@supremebeing7 why did you change it from a constant to a method?
Contributor
Author
There was a problem hiding this comment.
I had to do that for the character count rules in order to interpolate the number of characters. The rest I changed for consistency.
- Add config options - Add sample yml file - Add configuration to README - Rename character limit rules to correspond with configurability
Owner
|
@supremebeing7 perfect 👍 |
Owner
|
Released as v0.2.0! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
There's one piece that I have not done yet because I wanted to get your input, @mmozuras:
renaming the
FiftyCharSummaryandSeventyTwoCharLimitclasses. Since those are now configurable, it seems odd to have a specific number as a part of the class name. Would you agree?Also, if you like I can squash the commits down to one.
Let me know what you think.