Compilation issues with Sublime Text 2 - Ninja generator #89

Open
brupelo opened this Issue Oct 11, 2016 · 4 comments

Projects

None yet

2 participants

@brupelo
brupelo commented Oct 11, 2016 edited

Steps to reproduce:

  • Clone project
  • git submodule update --init --recursive
  • mkdir build && cd build
  • cmake .. -G "Sublime Text 2 - Project" -DCMAKE_BUILD_TYPE=Release
  • sublime_text sublime_text PBRT-V3.sublime-project
  • Build all

And the output will be:

ninja: error: 'src/ext/zlib/Release/zlibstatic.lib', needed by 'imgtool.exe', missing and no known rule to make it

What does it mean?

@mmp
Owner
mmp commented Nov 19, 2016

I can't reproduce this on OSX; a ninja build via cmake completes without errors. Unfortunately I don't have easy access to a Windows system, so can't be of much help debugging this.

@brupelo
brupelo commented Nov 19, 2016

Matt, mmm, the fact using cmake+ninja on macosx works out of the box but not on windows is... well, strange :) , if you got any suggestion in order to narrow this please let me know, I got windows and I could test it out.

@mmp mmp added a commit that referenced this issue Nov 22, 2016
@mmp Improvements to Windows build.
Add the missing zlibstatic dependency.
Remove hack from appveyor.yml that explicitly built zlib first.
May fix issue #89?
bf909f6
@mmp
Owner
mmp commented Nov 22, 2016

I found a Windows-specific issue in the cmake file that may have caused this. Could you try syncing to top of tree and see if this is fixed?

@brupelo
brupelo commented Nov 22, 2016

@mmp Hi, unfortunately that didn't do it, here's the current output

@mmp mmp added a commit that referenced this issue Nov 25, 2016
@mmp Improvements to Windows build.
Add the missing zlibstatic dependency.
Remove hack from appveyor.yml that explicitly built zlib first.
May fix issue #89?
842ca41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment