fix: use numerical enums when creating zod schema#108
Merged
Conversation
mnahkies
commented
Nov 12, 2023
| "eslint-plugin-jest": "^27.6.0", | ||
| "husky": "^8.0.3", | ||
| "jest": "^29.7.0", | ||
| "jest": "^30.0.0-alpha.1", |
Owner
Author
There was a problem hiding this comment.
Apparently inline snapshots aren't compatible with prettier@3 before this version 🤷 (jestjs/jest#14305 (comment))
mnahkies
force-pushed
the
mn/fix/numeric-enum-schemas
branch
from
b9dc22d to
ce43206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop ignoring the
enumproperty onnumberschemas when generatingzodschemas,which avoids
number is not assignable to 301 | 302 | 303type errors.uses a
z.union/z.literalworkaround asz.enumis not compatible with numbers (see also colinhacks/zod#2686 (comment))