fix: optional oneOf / allOf / anyOf / $ref's#110
Merged
Conversation
previously, these would never be marked as optional, even if the key they belonged to wasn't `required` this was made evident whilst testing #109 which relies on `oneOf` to handle arrays of `type` this moves that logic up into the AbstractSchemaBuilder, and applies it more predictably, as well as swapping the order such that `nullable` always comes before `optional`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, these would never be marked as optional, even if the key
they belonged to wasn't
requiredthis was made evident whilst testing #109
which relies on
oneOfto handle arrays oftypethis moves that logic up into the
AbstractSchemaBuilder, and applies it more predictably,as well as swapping the order such that
nullablealways comes beforeoptionalthis means that schemas like:
will correctly mark
allowed_actionsas optional, and schemas like:correctly mark
us_bank_accountas optional.note: the typescript types were already correct here. the problem wasn't picked up by typescript because were being stricter on the validation and then passing that to a looser type, eg: passing
Tto aT | undefinedparameter.