feat: experimental support for extracting inline schemas#123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Some
openapidefinitions don't make use of$ref's to name their schemas, which until now has resulted in the generated types/schemas being in-lined at the site of usage.I've found this is especially common when some packages that generate
openapischemas from your server implementation are used, as the additional metadata to create$ref's is often omitted (YMMV).This can make the code harder to read, and more awkward to consume, as you cannot easily use the generated types (without extracting them from another type), and the schemas simply can't be referenced.
Solution
Introduce a new experimental cli flag
--extract-inline-schemasthat will cause synthetic$ref's to be created from inline schemas on request and response bodies where the following is true:$refstring/numberarraywith$reffor itemsIt seems to work fairly well, and is primarily experimental as I may still adjust the name generation, and it could be interesting to attempt de-duplication of repeated schemas - though I suspect that'll be difficult to do whilst keeping semantically meaningful names.
I've not enabled it on any integration tests yet, but the change for the new example operations added in this PR looks like this:
typescript-koa
typescript-fetch