fix(typescript-fetch): omit optional query params#2
Merged
Conversation
filter out query parameters passed as undefined, unstead of passing them in the url as `name=` explicit null values will still be passed to the server
it serializes to either a repeated query param as you'd expect, or an empty string in the case of an empty array. todo: work out a way to test helper functions like this that happen to be generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filter out query parameters passed as undefined, unstead of passing them in the url as
name=explicit null values will still be passed to the server
prefix private methods with
_to reduce change of naming collisions with the generated public interface