Skip to content

fix: respect optional $ref properties #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mnahkies merged 2 commits into from
Apr 1, 2023
Merged

fix: respect optional $ref properties #22

mnahkies merged 2 commits into from
Apr 1, 2023

Conversation

@mnahkies
Copy link
Owner

@mnahkies mnahkies commented Apr 1, 2023 •
edited
Loading

Previously if an object property was a $ref then it would always be output as type T rather than T | undefined if it was not required.

@mnahkies mnahkies changed the title Mn/fix/support optional ref properties fix: respect optional $ref properties Apr 1, 2023
mnahkies
mnahkies commented Apr 1, 2023
View reviewed changes
packages/openapi-code-generator/src/typescript/common/model-builder.ts

return [
`"${name}"`,
isRequired ? "" : "?",
Copy link
Owner Author

@mnahkies mnahkies Apr 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix, the rest is just cleaning up the raw output a bit to make the unit test snapshot look nicer

@mnahkies mnahkies merged commit 32e80d8 into master Apr 1, 2023
@mnahkies mnahkies deleted the mn/fix/support-optional-ref-properties branch April 1, 2023 15:40
mnahkies added a commit that referenced this pull request Apr 1, 2023
@mnahkies
feat: rework zoa parsing
556fe66 
- ditch the middleware, it made types more complicated
- use infer to typecheck that the parsed value matches
  the type we expected

this led me to discover and fix these issues:
- #22
- #23
- #24
@mnahkies mnahkies mentioned this pull request Apr 1, 2023
Merged
mnahkies added a commit that referenced this pull request Apr 2, 2023
@mnahkies
feat: rework input schema parsing (#25)
7bae0ad 
- ditch the middleware, it made types more complicated / less accurate
- use infer to typecheck that the parsed value matches the type we
expected

this led me to discover and fix these issues:
- #22
- #23
- #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnahkies