fix: support array of 1 for query parameter arrays (round 2)#225
Merged
Conversation
- introduce `x-alpha-transform` concept, allowing for a arbitrary transformation function to be applied to a schema - not yet supported by `joi` - not yet supported by `type-builder` - only really useful for this specific case so far - detect query parameters of an array type, and parse as a `T | T[]`, and then transform to a `T[]` for convenience - does not yet support `$ref`d schemas properly relates #217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#220 got a bit off-track with scope creep.
this PR takes a similar approach, but for internal use only
z.preprocessto coerce an individual value to an array of 1 element, before parsing with the array schemajoiwe resort to a pretty hacky wrapping of the schema with a object that does the preprocessing, as thejoiextension API didn't work as I'd expected it to.will continue experimenting with making this a more generally useful feature for handling things like parsing
date-timestrings to be aDate, etc, separately.relates #217
Testing Notes
Need to improve automated test coverage still, but manually tested on a running server:
and it seems to be working correctly.