Skip to content

fix: request bodies can be optional#24

Merged
mnahkies merged 2 commits into
masterfrom
mn/fix/request-bodies-can-be-optional
Apr 1, 2023
Merged

fix: request bodies can be optional#24
mnahkies merged 2 commits into
masterfrom
mn/fix/request-bodies-can-be-optional

Conversation

@mnahkies

@mnahkies mnahkies commented Apr 1, 2023

Copy link
Copy Markdown
Owner

will help remind implementations to check for presence of request body when optional.

(the input parsing will throw an error if it's missing when required)

@mnahkies mnahkies enabled auto-merge (squash) April 1, 2023 16:16
@mnahkies mnahkies merged commit 810619c into master Apr 1, 2023
@mnahkies mnahkies deleted the mn/fix/request-bodies-can-be-optional branch April 1, 2023 16:19
mnahkies added a commit that referenced this pull request Apr 1, 2023
- ditch the middleware, it made types more complicated
- use infer to typecheck that the parsed value matches
  the type we expected

this led me to discover and fix these issues:
- #22
- #23
- #24
mnahkies added a commit that referenced this pull request Apr 2, 2023
- ditch the middleware, it made types more complicated / less accurate
- use infer to typecheck that the parsed value matches the type we
expected

this led me to discover and fix these issues:
- #22
- #23
- #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant