Skip to content

feat: rework input schema parsing#25

Merged
mnahkies merged 4 commits intomasterfrom
mn/fix/rework-zoa-parsing
Apr 2, 2023
Merged

feat: rework input schema parsing#25
mnahkies merged 4 commits intomasterfrom
mn/fix/rework-zoa-parsing

Conversation

@mnahkies
Copy link
Copy Markdown
Owner

@mnahkies mnahkies commented Apr 1, 2023 •
edited
Loading

  • ditch the middleware, it made types more complicated / less accurate
  • use infer to typecheck that the parsed value matches the type we expected

this led me to discover and fix these issues:

mnahkies added 4 commits April 1, 2023 17:25
@mnahkies
feat: rework zoa parsing
556fe66 
- ditch the middleware, it made types more complicated
- use infer to typecheck that the parsed value matches
  the type we expected

this led me to discover and fix these issues:
- #22
- #23
- #24
@mnahkies
fix: missing import
778f576
@mnahkies
fix: adjust joi runtime to match zod
a73f84d
@mnahkies
fix: support required parameters
fe1f149
@mnahkies mnahkies marked this pull request as ready for review April 2, 2023 11:04
@mnahkies mnahkies changed the title feat: rework zoa parsing feat: rework input schema parsing Apr 2, 2023
@mnahkies mnahkies enabled auto-merge (squash) April 2, 2023 11:06
@mnahkies mnahkies merged commit 7bae0ad into master Apr 2, 2023
@mnahkies mnahkies deleted the mn/fix/rework-zoa-parsing branch April 2, 2023 11:07
@mnahkies mnahkies mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mnahkies