Skip to content

fix: allow $ref to be used as a schema property#250

Merged
mnahkies merged 1 commit into
mainfrom
mn/fix/-is-valid-property
Sep 29, 2024
Merged

fix: allow $ref to be used as a schema property#250
mnahkies merged 1 commit into
mainfrom
mn/fix/-is-valid-property

Conversation

@mnahkies
Copy link
Copy Markdown
Owner

The SCIM v2 RFC includes a property named $ref on group membership, etc

Eg:
https://datatracker.ietf.org/doc/html/rfc7643

{
            "name" : "$ref",
            "type" : "reference",
            "referenceTypes" : [
              "User",
              "Group"
            ],
            "multiValued" : false,
            "description" : "The URI of the corresponding 'Group'
resource to which the user belongs.",
            "required" : false,
            "caseExact" : false,
            "mutability" : "readOnly",
            "returned" : "default",
            "uniqueness" : "none"
          },

Previously we were naively trying to resolve any $ref key we found as an OpenAPI reference

Now we still naively do this, but only if it quacks like a real $ref

@mnahkies mnahkies enabled auto-merge (squash) September 29, 2024 12:45
@mnahkies mnahkies merged commit 9c09191 into main Sep 29, 2024
@mnahkies mnahkies deleted the mn/fix/-is-valid-property branch September 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant