Conversation
mnahkies
force-pushed
the
mn/282/intersected-unions
branch
from
3921e8d to
e21f566
Compare
mnahkies
commented
Dec 21, 2024
| await expect(execute({foo: "bla"})).rejects.toThrow('"bar" is required') | ||
| }) | ||
|
|
||
| // TODO: https://github.com/hapijs/joi/issues/3057 |
Owner
Author
There was a problem hiding this comment.
Skipping this test so that I can merge the fix for the zod side without blocking on the joi builder. Raised an issue hapijs/joi#3057 to hopefully get some feedback on any existing ways to solve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergeis only available onZodObjectand so we must useintersectif aZodIntersectionorZodUnionis involved.it'd probably be simpler to just always use
intersectbut that comes with drawbacks like being unable topickoromitthe resulting schema.solves #282