Merged
Conversation
github now has official openapi definitions available here: https://github.com/github/rest-api-description and has deprecated the ones we were using previously from https://github.com/octokit/routes/ this change swaps over to using them, and refreshes the others. In the process a few problems emerged: - error in the new schema, fixed manually, see github/rest-api-description#2064 (comment) - angular codegen not liking string literal arrays for query params - "safe edit" code becoming out of date for a koa example - needed to change the ajv import used for the openapi schema - name collisions / invalid names for some github models. Fixed with a bandaid of prefixing by `t_` and converting `-` to `_` for now, however this feels a bit yuck and so plan to make this cleaner in a follow up change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github now has official openapi definitions available here: https://github.com/github/rest-api-description and has deprecated the ones we were using previously from https://github.com/octokit/routes/
this change swaps over to using the new ones, and refreshes the others. In the process a few problems emerged:
t_and converting-to_for now, however this feels a bit yuck and plan to make this cleaner in a follow up change.