chore: switch to pnpm and fix peer dependencies - #345
Merged
Conversation
mnahkies
force-pushed
the
mn/fix/peer-deps
branch
2 times, most recently
from
July 6, 2025 09:57
3a19b07 to
47c464b
Compare
mnahkies
force-pushed
the
mn/fix/peer-deps
branch
5 times, most recently
from
July 19, 2025 13:44
b5a42af to
5123be4
Compare
mnahkies
changed the title
mnahkies
force-pushed
the
mn/fix/peer-deps
branch
from
July 20, 2025 10:30
59cc1e4 to
dd61ecc
Compare
mnahkies
enabled auto-merge (squash)
July 20, 2025 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A somewhat reoccurring issue has been dependency updates introducing
peerDependencymisalignment that causes installation / run errors with tools likenpx.Originally I was planning to address this by introducing new CI steps that checked for this, but instead I've decided to give
pnpma go. As far as I understand it has the strictest rules of the common package managers around dependency resolution, and therefore if it works withpnpmit'll probably work with everything else.Making this change surfaced a number of implicit dependency issues across the repository, and unintentional reliance on
jestglobals.I'd be fairly keen to additionally do away with the
lernadependency, as its now only used for publishing the packages, but that's probably a job for another day.