fix: improve null support#40
Merged
Merged
Conversation
mnahkies
commented
Apr 22, 2023
|
|
||
| export type t_code_scanning_default_setup = { | ||
| languages?: "javascript" | "python" | "ruby"[] | ||
| languages?: ("javascript" | "python" | "ruby")[] |
Owner
Author
There was a problem hiding this comment.
Previously we erroneously made this property accept some javascript/python or an array of the string ruby only 🤦 - with the new helper functions we do a better job of adding ()
mnahkies
commented
Apr 22, 2023
| readonly first_patched_version: { | ||
| readonly identifier: string | ||
| } | null | null | ||
| } | null |
Owner
Author
There was a problem hiding this comment.
Other main change is to remove these redundant null types
mnahkies
commented
Apr 22, 2023
| message?: string | ||
| resource?: string | ||
| value?: string | null | number | string[] | ||
| value?: (string | null) | (number | null) | string[] |
Owner
Author
There was a problem hiding this comment.
Technically these () are superfluous, but probably not worth trying to change right now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nullin types