feat: initial support for anyOf#55
Merged
Merged
Conversation
mnahkies
commented
Apr 22, 2023
| : "" | ||
|
|
||
| result.push(object([...properties, additionalProperties])) | ||
| const emptyObject = !additionalProperties && properties.length === 0 ? "[key: string]: never" : "" |
Owner
Author
There was a problem hiding this comment.
Github spec includes schemas like:
schema:
type: object
properties: {}
additionalProperties: false
Often to represent an empty response. This should now type them more appropriately, hopefully without any majority usability issues introduced.
mnahkies
added a commit
that referenced
this pull request
Apr 23, 2023
- obtained from https://github.com/stripe/openapi - licensed as MIT (https://github.com/stripe/openapi/blob/master/LICENSE) although this is currently missing from the specification itself (see stripe/openapi#120) surfaced numerous issues that are now fixed: - #50 - #55 - #56 - #57 - #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #46