Skip to content

fix: dependency graph handles oneOf allOf nesting#73

Merged
mnahkies merged 2 commits into
masterfrom
mn/fix/dep-graph
Sep 16, 2023
Merged

fix: dependency graph handles oneOf allOf nesting#73
mnahkies merged 2 commits into
masterfrom
mn/fix/dep-graph

Conversation

@mnahkies
Copy link
Copy Markdown
Owner

the latest github api definitions (#72) include structures like:

    repository-rule-detailed:
      title: Repository Rule
      type: object
      description: A repository rule with ruleset details.
      oneOf:
      - allOf:
        - "$ref": "#/components/schemas/repository-rule-creation"
        - "$ref": "#/components/schemas/repository-rule-ruleset-info"
      - allOf:
        - "$ref": "#/components/schemas/repository-rule-update"
        - "$ref": "#/components/schemas/repository-rule-ruleset-info"

which weren't being considered by the dependency graph correctly, causing use before define errors to be emitted.

@mnahkies mnahkies enabled auto-merge (squash) September 16, 2023 11:01
@mnahkies mnahkies merged commit 52ca608 into master Sep 16, 2023
@mnahkies mnahkies deleted the mn/fix/dep-graph branch September 16, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant