fix: don't coerce strings#87
Merged
Merged
Conversation
coercing strings causes issues with objects like `{foo: undefined}`
as it coerces `undefined` to `"undefined"` rather than leaving it as
`undefined` / throwing an error if the property is not optional.
coercing numbers doesn't seem to suffer the same issue, and is needed
for parameters from route params / query strings since these always
start as a string.
the schema builder should probably become aware of when to
expect to receive a parsed JSON value rather than a string and adjust
it's use of coerce accordingly, but this will improve things in the
meantime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coercing strings causes issues with objects like
{foo: undefined}as it coercesundefinedto"undefined"rather than leaving it asundefined/ throwing an error if the property is not optional.coercing numbers doesn't seem to suffer the same issue, and is needed for parameters from route params / query strings since these always start as a string.
the schema builder should probably become aware of when to expect to receive a parsed JSON value rather than a string and adjust it's use of coerce accordingly, but this will improve things in the meantime.