chore: move generated files into a generated sub-directory#92
Merged
Conversation
mnahkies
commented
Nov 4, 2023
mnahkies
commented
Owner
- allows easy cleaning of the generated stuff
- also replace scripts with a find + xargs approach to run in parallel
- allows easy cleaning of the generated stuff - also replace scripts with a find + xargs approach to run in parallel
mnahkies
force-pushed
the
mn/chore/move-things-around
branch
from
ff0c129 to
c6d83b9
Compare
mnahkies
commented
Nov 4, 2023
|
|
||
| set -xeo pipefail | ||
|
|
||
| find ./integration-tests -mindepth 1 -maxdepth 1 -type d | xargs -n1 -P 8 basename | xargs -n1 -P 8 ./scripts/generate.template.sh |
Owner
Author
There was a problem hiding this comment.
There seems to be some kind of race condition where sometimes silent failures occur 😞 - but generally it seems to be working well and is now 5s wall clock time on my machine vs ~30s
mnahkies
added a commit
that referenced
this pull request
Nov 4, 2023
mnahkies
added a commit
that referenced
this pull request
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.