feat!: throw discriminable errors indicating point of failure#95
Merged
feat!: throw discriminable errors indicating point of failure#95
Conversation
48d6560 to
ca1a4d1
Compare
ca1a4d1 to
0f766ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if request validation or response validation failed you'd just get something like a
ZodErrorwithout much context as to where in the request processing failed.This change introduced a
KoaRuntimeErrorthat wraps all exceptions thrown during request processing and annotates them with additional context via aphaseproperty.The intention is that you can then mount a generic error handling middleware that can distinguish between request validation errors, etc.
See integration-tests/typescript-koa/src/petstore-expanded.yaml.ts for an example.
Breaking change: errors thrown are now wrapped in
KoaRuntimeErrorobjects.