check return value is not null (#18) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.03%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
mnbf9rca
added a commit
that referenced
this pull request
Jan 1, 2023
* create template function app * create skeleton of timescale.py * create tests identify_data_column (& test 100 🎉) * give test_timescale its own DB connection * github actions only allows CAPITAL envvars * Update run_tests.yml * test actual DB connection; add teardown_method * check return value is not null (#18) (#19) * test create_single_timescale_record against db * remove psycopg2 and rely on psycopg3(psycopg) * remove correct psycopg version * 'Refactored by Sourcery' (#16) Co-authored-by: Sourcery AI <> * replace recursive_json_parser with (working) recursively_deserialize * start writing to database * rename measurement_name to measurement_of * get rid of TimescaleConnection because psycopg3 does it * test for timescale_records_from_batch_of_events with mock psycopg and create_single_timescale_record * create_timescale_records_from_batch_of_events checks schema * created Test_create_single_timescale_record_with_mock * enable timeseries_to_timescale * 'Refactored by Sourcery' (#20) Co-authored-by: Sourcery AI <> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
mnbf9rca
added a commit
that referenced
this pull request
Oct 27, 2023
* create template function app * create skeleton of timescale.py * create tests identify_data_column (& test 100 🎉) * give test_timescale its own DB connection * github actions only allows CAPITAL envvars * Update run_tests.yml * test actual DB connection; add teardown_method * check return value is not null (#18) (#19) * test create_single_timescale_record against db * remove psycopg2 and rely on psycopg3(psycopg) * remove correct psycopg version * 'Refactored by Sourcery' (#16) Co-authored-by: Sourcery AI <> * replace recursive_json_parser with (working) recursively_deserialize * start writing to database * rename measurement_name to measurement_of * get rid of TimescaleConnection because psycopg3 does it * test for timescale_records_from_batch_of_events with mock psycopg and create_single_timescale_record * create_timescale_records_from_batch_of_events checks schema * created Test_create_single_timescale_record_with_mock * enable timeseries_to_timescale * 'Refactored by Sourcery' (#20) Co-authored-by: Sourcery AI <> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.