-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/missing measurement source (Sourcery refactored) #23
Fix/missing measurement source (Sourcery refactored) #23
Conversation
raise ValueError("Invalid publisher: emon processor only handles emon messages, not %s" % publisher) | ||
raise ValueError( | ||
f"Invalid publisher: emon processor only handles emon messages, not {publisher}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function emon_to_timescale
refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
raise ValueError("Invalid publisher: Glow processor only handles Glow messages, not %s" % publisher) | ||
raise ValueError( | ||
f"Invalid publisher: Glow processor only handles Glow messages, not {publisher}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function glow_to_timescale
refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
raise ValueError("Invalid publisher: Homie processor only handles Homie messages not %s" % publisher) | ||
|
||
raise ValueError( | ||
f"Invalid publisher: Homie processor only handles Homie messages not {publisher}" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function homie_to_timescale
refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring
)
publisher_to_send = override_publisher if override_publisher else publisher | ||
publisher_to_send = override_publisher or publisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function call_converter
refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity
) - Simplify conditional into switch-like form (
switch
)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.02%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)shared_code/homie.py
shared_code/glow.py
shared_code/emon.py
|
Pull Request #22 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
fix/missing_measurement_source
branch, then run:Help us improve this pull request!