Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Check labels passed to space entity #724

Merged
merged 9 commits into from Mar 12, 2021

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Mar 11, 2021

closes #709

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff sappelhoff marked this pull request as ready for review March 11, 2021 15:20
@sappelhoff sappelhoff changed the title Check labels passed to space entity [MRG] Check labels passed to space entity Mar 11, 2021
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just a tiny what's new entry? thanks a lot @sappelhoff

mne_bids/path.py Outdated Show resolved Hide resolved
@sappelhoff
Copy link
Member Author

maybe just a tiny what's new entry? thanks a lot @sappelhoff

done!

good to merge from my side once CIs are green.

@agramfort agramfort merged commit df9c1bf into mne-tools:master Mar 12, 2021
@agramfort
Copy link
Member

thx @sappelhoff

@sappelhoff sappelhoff deleted the space branch March 12, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we should probably restrict the kinds of "labels" that can be passed to entity: *_space-<label>
3 participants