MRG: Don't store age, sex, handedness for empty-room in participants.tsv #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
emptyroom-participant
branch
from
35d641a
to
c482b78
Compare
hoechenberger
commented
Dec 29, 2021
| @@ -222,7 +225,6 @@ def test_write_participants(_bids_validate, tmp_path): | |||
|
|
|||
| # if overwrite is False, then nothing should change from the above | |||
| with pytest.raises(FileExistsError, match='already exists'): | |||
| raw.info['subject_info'] = None | |||
There was a problem hiding this comment.
I assume this line was some leftover cruft from debugging
hoechenberger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 23 23
Lines 3490 3490
=======================================
Hits 3308 3308
Misses 182 182
Continue to review full report at Codecov.
|
jasmainak
approved these changes
Dec 29, 2021
sappelhoff
approved these changes
Dec 30, 2021
|
Thanks @hoechenberger 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across some datasets where, for whatever reason, a participant age etc. were included in
raw.info['subject_info']for empty-room recordings. This PR makes it so that such info isn't added toparticipants.tsvanymore.Merge checklist
Maintainer, please confirm the following before merging: