BUG: Fix bug with plot_alignment checks #10309
Conversation
|
Ah, I'm very sorry if I broke the forward solution plotting in my refactoring, it wasn't what I was focused on so I didn't check it as thoroughly. I'll review as soon as I can today. |
| @@ -8,7 +8,8 @@ | |||
| Here we compute the resting state from raw for data recorded using | |||
| a Neuromag VectorView system and a custom OPM system. | |||
| The pipeline is meant to mostly follow the Brainstorm :footcite:`TadelEtAl2011` | |||
| `OMEGA resting tutorial pipeline <bst_omega_>`_. | |||
| `OMEGA resting tutorial pipeline | |||
| <https://neuroimage.usc.edu/brainstorm/Tutorials/RestingOmega>`__. | |||
There was a problem hiding this comment.
That was intentional, it's an anonymous hyperlink in RST (which IIUC is for when you don't plan to reuse the same link name later)
|
Looks good, let me check all the plot alignment tutorial plots vs 0.24 though, one minute |
|
Do not compare to 0.24 but to https://mne.tools/dev/auto_examples/preprocessing/movement_detection.html?highlight=plot_alignment Bug exists there, too, so not due to this PR |
|
This one looks off too PR: https://41451-1301584-gh.circle-artifacts.com/0/dev/auto_examples/visualization/3d_to_2d.html?highlight=plot_alignment It's off in main too: https://mne.tools/dev/auto_examples/visualization/3d_to_2d.html?highlight=2d%203d |
|
Let's fix those separately (#10312) and just fix things here that this PR breaks, if any |
|
Ok, good to merge by me, separate PRs sound good |
|
Okay, I'll look into #10312 tomorrow hopefully, thanks for the quick look @alexrockhill ! |
Closes #10308
@dasdiptyajit feel free to see if this fixes your problem
Our input validation for
transwas deficient, this fixes it. cc @alexrockhill since I think this was your code at some point.It also touches all tutorials that use
plot_alignmentto see if it breaks anything...