New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default topomap interpolation a bit uglier than some time before #8425
Comments
@mmagnuski we're making a push to release in a couple of weeks, do you have time to look into this in that time? |
I might have some time for this next week, I'll try to look into it! |
I still remember about this issue, I might find some time for it tomorrow. |
I finally got to it. It turns out my intuition was correct, plot_topomap creates too many extrapolation points: It is better, but still could be improved (left: master, right: PR) I'll see how increasing the distance of extrapolation points and further reducing their number helps, but I would prefer not to overfit to my specific cap layout :), so I would appreciate if other EEG users that experienced this problem let me know.
|
PR on the way?
I would be great if the default could be the best option... just saying
… |
@agramfort Yes, its in progress, I linked it in the post above (#8645). |
I noticed that current topomap interpolation with
extrapolate='head'
produces more artifacts at the edges than in the previous version. Take a look at this:before
now
Now the topos look ok only in
extrapolate='local'
mode (so I've learnt to like the non-circular convex hull mask).I think I may be partly responsible for this. I have a vague memory of adding more extrapolation points some time ago to
extrapolate='head'
, but I can't find the PR now.I'll try to take a look at this in the upcoming week.
The text was updated successfully, but these errors were encountered: