Add exclude parameter to raw.plot_psd() #9519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Add changelog in API or new section?
I doubt this will break old code, so I'd put it as a new feature.
Add .. versionadded :: 0.24.0 tag?
sure, why not?
Add note somewhere (docstring?) to show how to plot the PSD for all channels (including bads)?
See my suggestion
agramfort
approved these changes
Jul 1, 2021
|
@drammock any idea what is wrong with the docstring? It ends with a ".", so I don't understand the error message. |
missing space between |
|
Ultraslow is timing out, otherwise looking good. |
|
thx @cbrnr ! |
cbrnr
force-pushed
the
add-exclude-raw-plot-psd
branch
from
a1938c5
to
f1ccc1c
Compare
|
Just pushed a hotfix |
cbrnr
force-pushed
the
add-exclude-raw-plot-psd
branch
from
f1ccc1c
to
e371fe5
Compare
drammock
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9441.
This adds an
excludeparameter toraw.plot_psd(), which makes it possible to plot the PSD of all channels (including bads) usingraw.plot_psd(exclude=[]).Questions/To Do:
.. versionadded :: 0.24.0tag?