Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Fix AR estimation #3637

Merged
merged 1 commit into from Oct 6, 2016
Merged

MRG: Fix AR estimation #3637

merged 1 commit into from Oct 6, 2016

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Oct 5, 2016

Previously our AR estimation averaged the estimated AR model coefficients across channels, this changes it to average values across channels before fitting the model.

It also implements some memory-saving techniques during comutation, namely processing one channel at a time.

Ready for review/merge from my end.

@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 87.36% (diff: 92.30%)

Sunburst

No coverage report found for master at 0ad50cb.

Powered by Codecov. Last update 0ad50cb...13b6a99

@larsoner
Copy link
Member Author

larsoner commented Oct 5, 2016

Come an @agramfort this one is easy :)

@agramfort agramfort merged commit 4b6a174 into mne-tools:master Oct 6, 2016
@agramfort
Copy link
Member

thx @Eric89GXL

@larsoner larsoner deleted the fix-ar branch October 6, 2016 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants