MRG, BUG: Fix handling of axes with constrained_layout=True #8344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
approved these changes
Oct 5, 2020
|
One Travis job timed out after successfully running all tests. |
|
Thanks @larsoner Can you do the backporting also? |
larsoner
added a commit
that referenced
this pull request
Oct 6, 2020
* BUG: Fix handling of axes with constrained_layout=True * FIX: Version
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
…s#8344) * BUG: Fix handling of axes with constrained_layout=True * FIX: Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We should only internally do
tight_layout(...)calls when axes were not created usingconstrained_layout=True. Our current code gets a matplotlib warning about disabling theconstrained_layoutof the axes.Also fixes a bug where we would raise as error instead of re-emit as a warning