MRG, BUG, VIZ: Fix overlay times #8377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jona-sassenhagen
reviewed
Oct 15, 2020
| @@ -289,8 +289,8 @@ def plot_epochs_image(epochs, picks=None, sigma=0., vmin=None, | |||
| this_image = combine_func(this_data * scalings[this_ch_type]) | |||
| # handle `order`. NB: this can potentially yield different orderings | |||
| # in each figure! | |||
| this_image, overlay_times = _order_epochs(this_image, epochs.times, | |||
| order, overlay_times) | |||
| this_image, _overlay_times = _order_epochs(this_image, epochs.times, | |||
There was a problem hiding this comment.
Ah it was overwriting overlay_times?
There was a problem hiding this comment.
Did I break this?
jona-sassenhagen
approved these changes
Oct 15, 2020
drammock
changed the title
agramfort
approved these changes
Oct 15, 2020
|
Example looks good, CI failure is spurious codecov failure. Merging. |
drammock
added a commit
that referenced
this pull request
Oct 15, 2020
* fix bug * fstrings * style * safer? * what's new * touch tutorial to re-render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes #8370