ENH: add Brain.set_time(time_in_seconds) #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Oct 23, 2020
larsoner
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
LGTM, feel free to merge once CIs and you are happy @GuillaumeFavelier
mne/viz/_brain/_brain.py
Outdated
Comment on lines
2460
to
2465
| """Set the time to display (in seconds). | ||
|
|
||
| Parameters | ||
| ---------- | ||
| time_sec : float | ||
| The time to show. |
There was a problem hiding this comment.
I wonder if it would be more future-proof to call the param time or t or so, in case we decide to add a (time_)unit kwarg later?
There was a problem hiding this comment.
I would also call it time for api consistency
There was a problem hiding this comment.
And say it docstring it should be seconds
GuillaumeFavelier
approved these changes
Oct 23, 2020
hoechenberger
approved these changes
Oct 23, 2020
agramfort
approved these changes
Oct 23, 2020
|
thx @drammock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes #8401