[MRG] BUG: Do not allow baseline removal after preload #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Oct 27, 2020
hoechenberger
changed the title
…e-after-preload [skip travis] [skip github]
|
One test on Azure fails because the test environment cannot be set up correctly. All others pass. All tests passed before merging the changelog from |
|
LGTM, feel free to merge and backport |
|
@larsoner merge if you're ok with this one |
larsoner
pushed a commit
that referenced
this pull request
Oct 27, 2020
* BUG: Do not allow baseline removal after preload * Make test more explicit
|
Backported, thanks @hoechenberger |
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Oct 27, 2020
* BUG: Do not allow baseline removal after preload * Make test more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this implement/fix?
In
masterand 0.21 it's possible to preloadEpochs, apply baseline correction, and (seemingly) remove it again viaapply_baseline(None). This should not be allowed: removing BL correction can only happen as long as the data has not been loaded.