MRG, ENH: Add volumetric support to labels_to_stc #8447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Oct 29, 2020
| if scale == 1.: | ||
| assert 0.42 < corr <= 0.47, corr | ||
| else: | ||
| # XXX even just a pure scaling does not work very well, bug... |
There was a problem hiding this comment.
I have a fix for this locally, but to save you some reviewing pain @agramfort feel free to review and merge this enhancement first
agramfort
approved these changes
Oct 31, 2020
|
thx @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #8438.
@ChristinaZhao feel free to try it with your data