Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Better split file handling in Report.parse_folder() #8486

Merged
merged 7 commits into from Nov 5, 2020
Merged

MRG: Better split file handling in Report.parse_folder() #8486

merged 7 commits into from Nov 5, 2020

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Nov 5, 2020 •
edited

Better split file handling in Reports: don't "report" on any splits but the first.

cc @agramfort, wdyt?

@hoechenberger hoechenberger changed the title WIP: Split file handling in Report WIP: Split file handling in Report.parse_folder() Nov 5, 2020
agramfort
agramfort reviewed Nov 5, 2020
View reviewed changes
mne/report.py Outdated
elif _endswith(fname, ('epo',)):
data = read_epochs(fname, preload=False)
elif _endswith(fname, ('ave',)):
data = read_evokeds(fname, condition=0, allow_maxshield=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call data inst ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hoechenberger
Copy link
Member Author

@agramfort can you check if this fixes your issue?

@hoechenberger hoechenberger changed the title WIP: Split file handling in Report.parse_folder() MRG: Better split file handling in Report.parse_folder() Nov 5, 2020
agramfort
agramfort approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @hoechenberger !

@mne-tools mne-tools deleted a comment from drammock Nov 5, 2020
@agramfort agramfort merged commit 7cc7766 into mne-tools:master Nov 5, 2020
3 of 4 checks passed
@agramfort
Copy link
Member

thx @hoechenberger

@hoechenberger hoechenberger deleted the report-split branch November 5, 2020 21:21
@larsoner
Copy link
Member

larsoner commented Nov 6, 2020

This broke CircleCI:

https://app.circleci.com/pipelines/github/mne-tools/mne-python/4556/workflows/229c2f13-d8c1-460e-b964-682d94c01ea9/jobs/23290

Can you look @hoechenberger ?

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Nov 6, 2020
Merged
hoechenberger added a commit to hoechenberger/mne-python that referenced this pull request Nov 6, 2020
@hoechenberger
FIX mne-tools#8486, Evoked and Epochs don't get split
7ef8438
larsoner pushed a commit that referenced this pull request Nov 6, 2020
@hoechenberger
[MRG] FIX #8486, Evoked and Epochs don't get split (#8491)
b9a7fb7 
* FIX #8486, Evoked and Epochs don't get split

* Update changelog

* Add @testing.requires_testing_data decorator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoechenberger @agramfort @larsoner