New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude GDF channels #8520
Exclude GDF channels #8520
Conversation
@cbrnr feel free to merge and backport thanks a lot |
Is there a short description on how to backport specific PRs? I don't remember how I did it because that's been a long time. |
Nowadays I:
Sorry for the bad formatting, on mobile. But maybe this is enough hints. If not I can flesh out out later |
* Exclude GDF channels * Fix units * Add test * Add changelog entry * Fix PEP8 * Fix GDF2 units
Thanks @larsoner, this worked perfectly! Should we add these instructions to our dev docs? One more question, I've pushed the changes directly to |
Yes push to upstream is correct. No way to get rid of that prompt that I know of, but lately it has gone away on its own, I think even the same day sometimes |
Feel free to add this information to the wiki, it's probably better there than the dev docs. Only maintainers really need to care about this, similar to our release instructions (which also live in the wiki) |
There's been talk of an advanced dev docs page getting added but I think I agree with @larsoner that backporting is rare enough that the wiki is the best place for it. |
Thanks, I've added a page to the wiki: https://github.com/mne-tools/mne-python/wiki/How-to-backport-a-change |
Fixes #8511. It seems like we neither implemented nor tested this feature. Let's see if existing tests pass, I'm going to add a specific test next.