New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, BUG: Fix support for KIT Berlin #8542
Conversation
@larsoner thank you very much for all your work. I'm sorry for this bad example, initially these channels in the system were made for measuring EEG, but here we don't really measure the EEG signal, but the voltage from the new OPM MEG sensors, that is the reason for these high amplitudes. We multiply these values with a gain factor to obtain the magnetic fields. Here is a picture from the MegLaboratory (a software provided from the manufacturer of the MEG device). In this program the value of the channel E14 at time 28.77s is -2.55V. I can ask the manager of the device if he has some old data where they really measured EEG signal, would that help? |
@UrbanM is it okay for me to add the dataset you created to the |
@larsoner I will try to provide a better sample dataset without wild EEG channels. I checked the value of the MEG channel "MEG 003" in the manufacturers software at time 28.770 s it is -8.89 pT. I also checked the value with the MNE-python with your "kit" branch, i get the value -8.88592475e-12. |
The current dataset is fine from the MNE-Python testing end of things. So I'm fine with putting it in MNE-testing-data, but if you don't want it living permanently there another similar short dataset is fine. |
Yes of course, if this dataset is OK, feel free to put it in MNE-testing-data. |
@agramfort ready for review/merge from my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsoner shall we backport?
* WIP: Add support for KIT Berlin * FIX: zero->AD * TST: Add test
@UrbanM simplifying your example to get rid of all of the
scalings
stuff and doing:You'll notice that the scale bar for EEG data is 40 uV. Your plot from version 0.20 had a pretty wild
400000.0 uV
scale bar which suggests things were wrong there, too (although at least they were non-zero!).This almost certainly isn't correct, unless I got very lucky -- I need to dig into why your
exg_gains
are all zero. And if those are being read correctly as zero, what the actually correct fallback gain is to use. Can you browse these data in some KIT (or other) software and let me know what the correct voltage of some value in some EEG channel at some time is supposed to be? For example, E14 at 28.77 seconds seems to be the top of a fairly smooth peak.I also have no idea if the names I gave to these constants are consistent, feel free to look at the diff and comment @UrbanM!
Closes #8535