/ mne-python Public
MRG, BUG: Fix support for KIT Berlin #8542
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
@UrbanM simplifying your example to get rid of all of the
scalingsstuff and doing:
You'll notice that the scale bar for EEG data is 40 uV. Your plot from version 0.20 had a pretty wild
400000.0 uVscale bar which suggests things were wrong there, too (although at least they were non-zero!).
This almost certainly isn't correct, unless I got very lucky -- I need to dig into why your
exg_gainsare all zero. And if those are being read correctly as zero, what the actually correct fallback gain is to use. Can you browse these data in some KIT (or other) software and let me know what the correct voltage of some value in some EEG channel at some time is supposed to be? For example, E14 at 28.77 seconds seems to be the top of a fairly smooth peak.
I also have no idea if the names I gave to these constants are consistent, feel free to look at the diff and comment @UrbanM!