Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG, VIZ: equal aspect ratio for inset sensor maps #8545

Merged
merged 3 commits into from Nov 20, 2020
Merged

MRG, VIZ: equal aspect ratio for inset sensor maps #8545

merged 3 commits into from Nov 20, 2020

Conversation

drammock
Copy link
Member

this is an element of #7751

@drammock
Copy link
Member Author

drammock commented Nov 20, 2020 •
edited

renderings:

before
Screenshot_2020-11-19_18-06-52

after
Screenshot_2020-11-19_18-07-26

before
before

after
after

@larsoner
Copy link
Member

Does it maintain the aspect during resize? That would be magical...

@drammock
Copy link
Member Author

Does it maintain the aspect during resize? That would be magical...

Yes! 🧙‍♂️

@drammock drammock changed the title VIZ: equal aspect ratio for inset sensor maps MRG, VIZ: equal aspect ratio for inset sensor maps Nov 20, 2020
@larsoner
Copy link
Member

Thanks @drammock -- I think this one is worth a latest.inc update in the BUG section -- feel free to add and merge!

@drammock drammock merged commit 7586635 into mne-tools:master Nov 20, 2020
@drammock drammock deleted the fix-inset-aspect branch November 20, 2020 17:00
@drammock drammock mentioned this pull request Nov 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drammock @larsoner @agramfort